Skip to content

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Nov 2, 2024

Change Summary

The call to the synchronous celery.send_task() method in the asynchronous endpoint is wrapped in asyncio.to_thread to avoid event loop blocking, in particular when RabbitMQ is unavailable.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Nov 2, 2024
@IlyasDevelopment IlyasDevelopment added the ci:skip-changelog Add this label to skip changelog file check label Nov 2, 2024
@codecov
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.03%. Comparing base (d465bdf) to head (ea996fd).
Report is 80 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #116   +/-   ##
========================================
  Coverage    93.03%   93.03%           
========================================
  Files          129      129           
  Lines         3088     3089    +1     
  Branches       241      241           
========================================
+ Hits          2873     2874    +1     
  Misses         157      157           
  Partials        58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyasDevelopment IlyasDevelopment merged commit 87044fb into develop Nov 2, 2024
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-19794 branch November 2, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants