Skip to content

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Dec 18, 2024

Change Summary

Previously, the auth unit test was flaky in CI due to access token expiration. Its lifetime has now been extended from 1 to 5 seconds. The unit tests were rerun several times and passed successfully.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Dec 18, 2024
@IlyasDevelopment IlyasDevelopment added the ci:skip-changelog Add this label to skip changelog file check label Dec 18, 2024
@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review December 18, 2024 08:30
Copy link
Member

@dolfinus dolfinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the same changes to DataRentgen

@IlyasDevelopment IlyasDevelopment merged commit 5be1c5d into develop Dec 18, 2024
19 of 20 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-21952 branch December 18, 2024 08:56
@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d8bc63c) to head (004ce01).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #173   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants