feat(bindings): tile and bin functions parity — emitters / table functions / getters#102
Open
estebanzimanyi wants to merge 2 commits intomainfrom
Open
feat(bindings): tile and bin functions parity — emitters / table functions / getters#102estebanzimanyi wants to merge 2 commits intomainfrom
estebanzimanyi wants to merge 2 commits intomainfrom
Conversation
…s/tpoint-tile/tile-getters Consolidates 6 parity branches covering tiling and binning: - feat/table-fn-bins: span table functions for binning - feat/parity-temporal-tile-emitters: temporal tile emitter functions - feat/parity-temporal-tile-tablefunctions: temporal tile table-valued functions - feat/parity-tpoint-tile: tpoint tile split functions - feat/parity-tile-getters: temporal tile getter functions - feat/parity-single-tile-getters: single tile getter functions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Split/valueTimeSplit) Adds the missing RegisterTemporalTileSplit method to TemporalTypes which was called in LoadInternal but never declared or implemented. Provides table functions: timeSplit(temporal, interval [, timestamptz]) → for all 6 temporal types valueSplit(tint, integer [, integer]) → value-partitioned tint valueSplit(tfloat, double [, double]) → value-partitioned tfloat valueTimeSplit(tint/tfloat, size, interval [, origin, torigin]) All use the spaceSplit pattern: Bind pre-computes all fragments via MEOS into a GlobalTableFunctionState, Exec streams them in STANDARD_VECTOR_SIZE chunks. Also fixes temporal literals in 025_temporal_tile_split.test to use explicit UTC offsets (+00) so the test is timezone-independent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
estebanzimanyi
added a commit
that referenced
this pull request
May 5, 2026
…istance Parity tests activated (21/23 files now pass; 2 tile/split files remain skipped pending table-function architecture, tracked by PRs #102/#110): 015_span_aggfuncs — SetUnionAgg / SpanUnionAgg / extent (20 assertions) 022_temporal — temporal accessors + operators (32 assertions) 032_temporal_box — tbox constructors + expandValue/expandTime (3 assertions) 032_temporal_topops — temporal @> tbox / && temporal / -|- tstzspan (3 assertions) 036_tnumber_distance — tint<->tint, nad, nearestApproachDistance (3 assertions) 040_temporal_aggfuncs — TcountAgg/TandAgg/TminAgg/TsumAgg/extent (5 assertions) 042_temporal_waggfuncs — WminAgg/WmaxAgg/WsumAgg (3 assertions) 050_geo_inventory — geo surface manifest activated (1 assertion) 009_time_ops — tstzset/tstzspan + interval shift; tstzspan <-> INTERVAL (4 assertions) Bug fixes: - tstzspan/tstzset <-> operator: was registered as INTERVAL but implementation returned double, causing INTERNAL crash. Fixed Distance_span_value, Distance_value_span (use distance_span_timestamptz), Distance_span_span (dispatch on T_TSTZSPAN), Distance_set_value/Distance_value_set/ Distance_set_set (tstzset case). All time-type distances now return interval_t normalised to days+micros so "2 days" formats correctly. - expandValue(tbox, INTEGER): TboxExpandValueExecutor<int64_t> caused INTERNAL error "Expected vector of type INT64, but found vector of type INT32". Fixed template parameter to int32_t. - SetUnionAgg(date): date_to_set called raw DuckDB date_t without epoch offset conversion, producing dates 30 years in future. Added date_to_set_duckdb wrapper using ToMeosDate(). New registrations: - "+", {tstzset, INTERVAL} → tstzset: shift alias (MobilityDB @> parity) - "+", {tstzspan, INTERVAL} → tstzspan: shift alias - SecondsToInterval helper in time_util.hpp Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
estebanzimanyi
added a commit
that referenced
this pull request
May 10, 2026
…istance Parity tests activated (21/23 files now pass; 2 tile/split files remain skipped pending table-function architecture, tracked by PRs #102/#110): 015_span_aggfuncs — SetUnionAgg / SpanUnionAgg / extent (20 assertions) 022_temporal — temporal accessors + operators (32 assertions) 032_temporal_box — tbox constructors + expandValue/expandTime (3 assertions) 032_temporal_topops — temporal @> tbox / && temporal / -|- tstzspan (3 assertions) 036_tnumber_distance — tint<->tint, nad, nearestApproachDistance (3 assertions) 040_temporal_aggfuncs — TcountAgg/TandAgg/TminAgg/TsumAgg/extent (5 assertions) 042_temporal_waggfuncs — WminAgg/WmaxAgg/WsumAgg (3 assertions) 050_geo_inventory — geo surface manifest activated (1 assertion) 009_time_ops — tstzset/tstzspan + interval shift; tstzspan <-> INTERVAL (4 assertions) Bug fixes: - tstzspan/tstzset <-> operator: was registered as INTERVAL but implementation returned double, causing INTERNAL crash. Fixed Distance_span_value, Distance_value_span (use distance_span_timestamptz), Distance_span_span (dispatch on T_TSTZSPAN), Distance_set_value/Distance_value_set/ Distance_set_set (tstzset case). All time-type distances now return interval_t normalised to days+micros so "2 days" formats correctly. - expandValue(tbox, INTEGER): TboxExpandValueExecutor<int64_t> caused INTERNAL error "Expected vector of type INT64, but found vector of type INT32". Fixed template parameter to int32_t. - SetUnionAgg(date): date_to_set called raw DuckDB date_t without epoch offset conversion, producing dates 30 years in future. Added date_to_set_duckdb wrapper using ToMeosDate(). New registrations: - "+", {tstzset, INTERVAL} → tstzset: shift alias (MobilityDB @> parity) - "+", {tstzspan, INTERVAL} → tstzspan: shift alias - SecondsToInterval helper in time_util.hpp Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates 6 individual parity PRs (previously #62, #79, #81, #82, #85, #88) into one squashed commit.
Test plan
test/sql/parity/025_temporal_tile_getters.testtest/sql/parity/026_single_tile_getters.testtest/sql/parity/058_tile_emitters.testtest/sql/parity/059_split_path.test🤖 Generated with Claude Code