Skip to content

Add temporalFooter for TemporalParquet KV_METADATA#146

Closed
estebanzimanyi wants to merge 1 commit into
fix/bump-meos-pinfrom
lake/temporal-footer
Closed

Add temporalFooter for TemporalParquet KV_METADATA#146
estebanzimanyi wants to merge 1 commit into
fix/bump-meos-pinfrom
lake/temporal-footer

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

temporalFooter builds the TemporalParquet footer-metadata JSON manifest for COPY ... TO '*.parquet', faithful to the ratified opaque-MEOS-WKB spec. The test covers the deterministic footer assertions and the KV_METADATA round-trip. Stacked on #134 (fix/bump-meos-pin) because current main pins a pre-MeosType MEOS that no longer compiles; base retargets to main once #134 lands. End-to-end MEOS-WKB round-trip and native-scalar sidecar pushdown coverage are deferred to a follow-up gated on the MobilityDuck binding-stability fix, since exercising many sequential MEOS calls in one process trips a pre-existing non-deterministic native crash tracked in a separate lane.

temporalFooter builds the TemporalParquet footer-metadata JSON manifest
for COPY ... TO '*.parquet', faithful to the ratified opaque-MEOS-WKB
spec. The test covers the deterministic footer assertions and the
KV_METADATA round-trip. End-to-end MEOS-WKB round-trip and native-scalar
sidecar pushdown coverage are deferred to a follow-up gated on the
MobilityDuck binding-stability fix, since exercising many sequential
MEOS calls in one process trips a pre-existing non-deterministic native
crash tracked in a separate lane.
@estebanzimanyi
Copy link
Copy Markdown
Member Author

The five files in this PR (CMakeLists.txt, src/include/temporal/temporal_parquet.hpp, src/temporal/temporal_parquet.cpp, src/mobilityduck_extension.cpp, test/sql/parquet/temporal_parquet.test) are all delivered in #158 (rebased onto current main, with the registration call already wired into LoadInternal and the test file already covering the round-trip). Closing as superseded — please review the consolidated content in #158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant