test(parity): 005_span_ops.test — span operators regression mirror#17
Merged
nhungoc1508 merged 1 commit intomainfrom May 4, 2026
Merged
test(parity): 005_span_ops.test — span operators regression mirror#17nhungoc1508 merged 1 commit intomainfrom
nhungoc1508 merged 1 commit intomainfrom
Conversation
…ression Ports mobilitydb/test/temporal/queries/005_span_ops.test.sql to test/sql/parity/005_span_ops.test in DuckDB sqllogic format. Active queries cover containment (@>, <@), overlap (&&), span-span adjacency (-|-), equality (=), span-span union (+), span-span intersection (*), span-span difference (-, returns SpanSet), and span-vs-value / span-vs-span distance (<->). Skipped sections, each with a technical note: - Position predicates between span and value (-|-, <<, >>, &<, &>): registered in src/temporal/span.cpp with return type SpanType instead of BOOLEAN; the impls already return bool from MEOS. - Disjoint-union case `floatspan '[1, 1]' + floatspan '[3, 4]'`: returns a SpanSet in MEOS, but `+` is registered as returning SpanType. - Value-value distance `1.0 <-> 1.0`: not registered (MEOS symbol: distance_value_value). Full suite passes (752 assertions, 14 test cases).
estebanzimanyi
force-pushed
the
feat/parity-span-ops
branch
from
4d631f3 to
8f8eebd
Compare
Member
Author
|
Refreshed against current main: removed mode skip blocks for now-landed bindings — Surfaced a new finding: Net change: -21 lines after the wider skip. All 23 query assertions pass locally with TZ=UTC. |
estebanzimanyi
added a commit
that referenced
this pull request
Apr 28, 2026
Single-file inventory of MobilityDB's mobilitydb/test/geo/queries/ surface. Rather than one parity file per upstream regression file, this lists what each file covers, what's bound in MobilityDuck today, and what's missing. Bound surface (per direct audit of src/geo/tgeompoint.cpp): - tgeompoint / tgeometry I/O for instant / discrete / continuous / sequence-set - asText / asEWKT / memSize / interp / round / transform - Constructors (TGEOMPOINT, tgeompointInst, tgeompointSeq, tgeompointSeqSet) - Spatial accessors: getX/Y/Z, length, cumulativeLength, speed, direction, azimuth, angularDifference, trajectory - Topological predicates: e/a/t variants of Contains, Disjoint, Dwithin, Intersects, Touches - Set ops: makeSimple, isSimple, stops - Restrictions: atGeometry, atStbox, atValues, atTime and the matching minus* - Modification: appendInstant, appendSequence, insert, update, deleteTime, merge - Comparison: temporal_eq / temporal_ne / etc. - twCentroid, shortestLine, distance_gs, collect_gs Unbound surface (per upstream regression file, with cross-references to the temporal-side parity-batch PRs that cover the same gap): - 051_stbox: stbox tests (whole file currently skipped in test/sql/stbox.test for DuckDB 1.4 signature issues). - 052_tgeo / 052_tpoint: mostly bound — per-type ports would mirror PRs #13 / #17 / #18 patterns. - 053_*_inout: asMFJSON / asWKB / asHexWKB / asGeoJSON — verify which are bound. - 054_*_compops: same parser blocker as PR #24's 030 (?= / #=). - 056_*_spatialfuncs: bulk bound; setSRID-on-temporal and reference-system accessors missing. - 058_*_tile: same gap as PR #23's 025 but for tspatial. - 060_*_topops: same pattern as PR #25's 032_temporal_topops. - 062_*_posops: same pattern as PR #24's 034_temporal_posops plus spatial-direction operators. - 064_*_distance: <-> for tgeo / tpoint; partially bound (shortestLine, distance_gs). - 066_tpoint_similarity: specialisation of PR #23's 038. - 068_*_aggfuncs: same architectural blocker as PR #21 (no AggregateFunction infra). Suite: 747 assertions, 23 test cases.
This was referenced Apr 29, 2026
nhungoc1508
pushed a commit
that referenced
this pull request
May 4, 2026
Single-file inventory of MobilityDB's mobilitydb/test/geo/queries/ surface. Rather than one parity file per upstream regression file, this lists what each file covers, what's bound in MobilityDuck today, and what's missing. Bound surface (per direct audit of src/geo/tgeompoint.cpp): - tgeompoint / tgeometry I/O for instant / discrete / continuous / sequence-set - asText / asEWKT / memSize / interp / round / transform - Constructors (TGEOMPOINT, tgeompointInst, tgeompointSeq, tgeompointSeqSet) - Spatial accessors: getX/Y/Z, length, cumulativeLength, speed, direction, azimuth, angularDifference, trajectory - Topological predicates: e/a/t variants of Contains, Disjoint, Dwithin, Intersects, Touches - Set ops: makeSimple, isSimple, stops - Restrictions: atGeometry, atStbox, atValues, atTime and the matching minus* - Modification: appendInstant, appendSequence, insert, update, deleteTime, merge - Comparison: temporal_eq / temporal_ne / etc. - twCentroid, shortestLine, distance_gs, collect_gs Unbound surface (per upstream regression file, with cross-references to the temporal-side parity-batch PRs that cover the same gap): - 051_stbox: stbox tests (whole file currently skipped in test/sql/stbox.test for DuckDB 1.4 signature issues). - 052_tgeo / 052_tpoint: mostly bound — per-type ports would mirror PRs #13 / #17 / #18 patterns. - 053_*_inout: asMFJSON / asWKB / asHexWKB / asGeoJSON — verify which are bound. - 054_*_compops: same parser blocker as PR #24's 030 (?= / #=). - 056_*_spatialfuncs: bulk bound; setSRID-on-temporal and reference-system accessors missing. - 058_*_tile: same gap as PR #23's 025 but for tspatial. - 060_*_topops: same pattern as PR #25's 032_temporal_topops. - 062_*_posops: same pattern as PR #24's 034_temporal_posops plus spatial-direction operators. - 064_*_distance: <-> for tgeo / tpoint; partially bound (shortestLine, distance_gs). - 066_tpoint_similarity: specialisation of PR #23's 038. - 068_*_aggfuncs: same architectural blocker as PR #21 (no AggregateFunction infra). Suite: 747 assertions, 23 test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
mobilitydb/test/temporal/queries/005_span_ops.test.sqltotest/sql/parity/005_span_ops.testin DuckDB sqllogic format. Same shape as the earlier parity files: active queries reflect MobilityDuck's display format; queries that hit a missing binding or known wrong-return-type registration are wrapped inmode skipwith a short technical note.Active coverage:
@>,<@),&&),-|-),=),+),*) including the empty-overlap NULL case,-, returnsSpanSetfor both empty / single / multi-component results),<->).Skipped — each with a one-line technical note:
,<<,>>,&<,&>`)floatspan '[1, 1]' + floatspan '[3, 4]'SpanSetin MEOS, but+is registered asSpanType1.0 <-> 1.0distance_value_valueTest plan
make releasethenTZ=UTC ./build/release/test/unittest "<proj>/test/*"— full suite passes (752 assertions across 14 test cases).Drafted because the position-predicate skip in this file overlaps with the in-flight position-predicates fix PR; mark ready / merge once that lands.