Skip to content

test(parity): 022_temporal.test — representative sample of upstream temporal regression#22

Merged
nhungoc1508 merged 1 commit intomainfrom
feat/parity-temporal
May 4, 2026
Merged

test(parity): 022_temporal.test — representative sample of upstream temporal regression#22
nhungoc1508 merged 1 commit intomainfrom
feat/parity-temporal

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

Summary

Ports a section-by-section representative sample of mobilitydb/test/temporal/queries/022_temporal.test.sql (3296 lines) to test/sql/parity/022_temporal.test. Each upstream section gets 1-3 queries that exercise the surface; full per-type coverage is left for follow-up files.

Active coverage (31 assertions)

Section Surface
I/O instants tbool / tint / tfloat / ttext literal parsing
I/O parse errors tbool '2@...', tfloat 'ABC@...'
I/O discrete sequence tint '{...}', tfloat '{...}'
I/O continuous sequence tint '[...]', tfloat '[...]'
Constructors TINT / TFLOAT / TBOOL / TTEXT (value, timestamptz)
Accessors tempSubtype, interp, startValue, endValue, minValue, maxValue, valueN, duration, timeSpan
Comparison =, <>, temporal_cmp
Transformations shiftValue
Restrictions atValues, atMin, atMax
Modifications appendInstant

Skip blocks (gap manifest)

Section Gap
Utility mobilitydb_version() / mobilitydb_full_version() not registered
Step interpolation parsing Interp=Step;[...] literal — verify output formatting before activating
tboolSeq / tintSeq / tfloatSeq / ttextSeq with 'discrete' 2-arg form needs verification
scaleValue(tint, n) Returns input unchanged for tint (verified). Likely a MobilityDuck wrapper bug; MEOS symbol: tnumber_scale_value
tsample / tprecision Not yet checked. MEOS: temporal_tsample, temporal_tprecision
Aggregates (tcount, tand, tor, tmin, tmax, tsum) Same architectural gap as PR #21 — no AggregateFunction registrations in MobilityDuck

Test plan

  • make release then TZ=UTC ./build/release/test/unittest "<proj>/test/*" — full suite passes (778 assertions across 14 test cases).

Drafted because this is a representative sample, not a full 1:1 port. Follow-up parity files (e.g. per-section per-type) will refine.

…ne upstream)

Ports a section-by-section representative sample of
mobilitydb/test/temporal/queries/022_temporal.test.sql (3296 lines)
to test/sql/parity/022_temporal.test. Each upstream section gets
1-3 queries that exercise the surface; full per-type coverage is
left for follow-up files.

Active sections (31 assertions, all passing):
- I/O for tbool / tint / tfloat / ttext instants, discrete sequences,
  continuous sequences, with associated parse-error assertions
- Constructor scalars TINT / TFLOAT / TBOOL / TTEXT
- Accessors: tempSubtype, interp, startValue, endValue, minValue,
  maxValue, valueN, duration, timeSpan
- Comparison: =, <>, temporal_cmp
- Transformations: shiftValue
- Restrictions: atValues, atMin, atMax
- Modifications: appendInstant

Skip blocks (each with a one-line technical note):
- Utility: mobilitydb_version() / mobilitydb_full_version() not
  registered.
- Step interpolation parsing: `Interp=Step;[...]` literal — verify
  output formatting before activating.
- tboolSeq / tintSeq / tfloatSeq / ttextSeq with explicit
  interpolation-text 2nd argument: needs verification.
- scaleValue: returns the input unchanged for tint inputs (verified
  the 2-scaled tint matches the 1-scaled version), likely a wrapper
  bug. MEOS symbol: tnumber_scale_value.
- tsample / tprecision: not yet checked. MEOS: temporal_tsample,
  temporal_tprecision.
- Aggregate functions (tcount, tand, tor, tmin, tmax, tsum):
  same architectural gap as 015_span_aggfuncs (no AggregateFunction
  registrations in MobilityDuck).

Full suite passes (778 assertions, 14 test cases).
@estebanzimanyi
Copy link
Copy Markdown
Member Author

Refreshed: replaced the mobilitydb_version() skip block with a query against the brand-divergent mobilityduck_version() (PR #28 added it). Retained other skip blocks pending verification — they cover step-interp parsing, tboolSeq 2-arg form, scaleValue regression (MobilityDuck wrapper bug), tsample/tprecision presence check, and the architectural aggregate-function gap (no AggregateFunction infra yet).

@estebanzimanyi estebanzimanyi marked this pull request as ready for review May 1, 2026 19:13
@nhungoc1508 nhungoc1508 merged commit 6ffdd39 into main May 4, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants