Support for custom rules by schema patching#41
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole GBFS specification is not possible to represent statically in the JSON schema. The canonical validator has chosen to solve this by dynamically patching it in runtime, e.g. to solve dependencies between files. This is the same approach taken here:
Each Version instance may be instantiated with a map of custom-rule-lists-per-file. The rule is an implementation of the CustomRuleSchemaPatcher interface, which takes a schema document context and a map of the files being validated. The implementation may then return a modified version of the schema with dynamic rules added to it based on the files being validated.