Skip to content

chore: Release asset#2134

Merged
jcpitre merged 5 commits intomasterfrom
releaseAsset
Mar 12, 2026
Merged

chore: Release asset#2134
jcpitre merged 5 commits intomasterfrom
releaseAsset

Conversation

@jcpitre
Copy link
Copy Markdown
Contributor

@jcpitre jcpitre commented Mar 12, 2026

Closes #2009

This PR replaces #2063
Summary:

Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).

Expected behavior:

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions release workflow to publish the built CLI and GUI JARs to GitHub Releases using a different release-asset upload action.

Changes:

  • Replace actions/upload-release-asset@v1 with softprops/action-gh-release@v2 for CLI and GUI JAR uploads.
  • Switch from asset_path/asset_name to files (and add name) for those uploads.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .github/workflows/publish_assets.yml Outdated
Comment thread .github/workflows/publish_assets.yml Outdated
@jcpitre jcpitre marked this pull request as ready for review March 12, 2026 15:34
@jcpitre jcpitre requested a review from davidgamez March 12, 2026 15:57
@github-actions
Copy link
Copy Markdown
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 8be231b
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1000 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

3 out of 1003 sources (~0 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-9
🔍 System errors for mdb-1114 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1114 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-1123 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-9 (reference)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]
🔍 System errors for mdb-9 (latest)
[
  {
    "code": "i_o_error",
    "severity": "ERROR",
    "totalNotices": 1,
    "sampleNotices": [
      {
        "exception": "java.util.zip.ZipException",
        "message": "Archive is not a ZIP archive"
      }
    ]
  }
]

💾 Out of Memory Check

No datasets experienced an OutOfMemoryError.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.42 5.81 ⬆️+0.39
Median -- 1.62 1.96 ⬆️+0.35
Standard Deviation -- 21.62 24.09 ⬆️+2.47
Minimum in References Reports mdb-1105 0.48 0.62 ⬆️+0.14
Maximum in Reference Reports mdb-2014 597.16 684.63 ⬆️+87.47
Minimum in Latest Reports mdb-299 0.51 0.58 ⬆️+0.07
Maximum in Latest Reports mdb-2014 597.16 684.63 ⬆️+87.47
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 552.54 MiB 557.83 MiB ⬆️+5.29 MiB
Median -- 323.93 MiB 327.93 MiB ⬆️+4.00 MiB
Standard Deviation -- 971.67 MiB 989.16 MiB ⬆️+17.49 MiB
Minimum in References Reports mdb-2297 39.56 MiB 415.93 MiB ⬆️+376.37 MiB
Maximum in Reference Reports mdb-1090 8.88 GiB 7.38 GiB ⬇️-1.50 GiB
Minimum in Latest Reports mdb-2034 387.93 MiB 38.48 MiB ⬇️-349.44 MiB
Maximum in Latest Reports mdb-2014 8.70 GiB 8.75 GiB ⬆️+49.67 MiB

@jcpitre jcpitre changed the title Release asset chore: Release asset Mar 12, 2026
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcpitre
Copy link
Copy Markdown
Contributor Author

jcpitre commented Mar 12, 2026

Tested by creating a branch that commented out all release triggers in all the actions (except publish_assets.yml) and doing a pre-release from this branch.
All files were uploaded properly: gtfs-validator-100.0.0-cli.jar, gtfs-validator-100.0.0-gui.jar, javadocs.zip and rules.json. (I used tag v100.0.0 to make it obvious it was not a proper release).
Deleted the release, the tag and the branch afterwards.

@jcpitre jcpitre merged commit 3a39522 into master Mar 12, 2026
81 of 82 checks passed
@jcpitre jcpitre deleted the releaseAsset branch March 12, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace GitHub action upload-release-asset

4 participants