fix: cartesian product with gtfsdatasets in query #1261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1221.
Details
Previously, the query used to filter feeds by bounding box did not properly join
GtfsDatasetandGtfsFeed, resulting in a cartesian product. This caused theST_Covers(...)spatial filter to be applied incorrectly or not at all.The query has been updated to explicitly join
GtfsDatasetonfeed_idwhen applying bounding box filters, preventing duplicate table references and ensuring the spatial filtering works as intended.Validation
The following request now returns the correct GTFS feed for the Lisbon area (as expected):
Example response from
dev:Sample output
[ { "id": "mdb-1272", "data_type": "gtfs", ... "provider": "Cascais Próxima, E.M., S.A.", ... "locations": [ { "country_code": "PT", "municipality": "Cascais e Estoril", ... }, ... ], "latest_dataset": { "id": "mdb-1272-202502251645", "bounding_box": { "minimum_latitude": 38.679561, "maximum_latitude": 38.763594, "minimum_longitude": -9.484887, "maximum_longitude": -9.313059 }, ... } } ]✅ Verified locally pointing to
dev.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything