chore: Removed feature flags that are not in use#1546
Conversation
….com:MobilityData/mobility-feed-api into 594-remove-feature-flags-that-are-not-in-use
|
We can add to the list of flags to remove:
cc: @emmambd |
….com:MobilityData/mobility-feed-api into 594-remove-feature-flags-that-are-not-in-use
|
*Lighthouse ran on https://mobility-feeds-dev--pr-1546-7xkwebxn.web.app/ * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1546-7xkwebxn.web.app/feeds * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1546-7xkwebxn.web.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1546-7xkwebxn.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1546-7xkwebxn.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
|
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1546-7xkwebxn.web.app |
| gbfs: false, | ||
| }; | ||
| if (config.enableGbfsInSearchPage) { | ||
| checkedFeedTypes.gbfs = checkboxData[2].checked; | ||
| } |
There was a problem hiding this comment.
GBFS no longer appears in the Search Filters, on line 126 add gbfs: checkboxData[2].checked;
| md={2} | ||
| sx={{ | ||
| minWidth: config.enableFeatureFilterSearch ? '275px' : '220px', | ||
| minWidth: '220px', |
There was a problem hiding this comment.
since enableFeatureFilterSearch is removed and assumed to always be true, the value should be 275px
| if (config.enableGbfsInSearchPage) { | ||
| dataTypesCheckboxData.push({ | ||
| title: t('common:gbfs'), | ||
| checked: selectedFeedTypes.gbfs, | ||
| type: 'checkbox', | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
same for this, this removed gbfs. add it to dataTypesCheckboxData under gtfsRt
Alessandro100
left a comment
Alessandro100
left a comment
There was a problem hiding this comment.
looks go to me, nice stuff ✅
|
Unused feature flags have been removed from prod. |
3 participants
Summary:
Closes #594
Expected behavior:
After this PR is merged, feature flags will be removed in DEV, QA, and Prod environments.
Testing tips:
Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything