You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our Sentry / Vercel logs, we are getting a lot of Error: {"detail":/// not foudn
After investigation the reasons we get this error are
(few) Feeds that were not able to load due to memory issues (fix is done in the API)
Bots were getting pointed to wrong URLs (gtfs_rt when it should of been gtfs) through the structured data
Bots were trying to access feeds that were WIP and not published to the public -> correct behaviour of our application
In this PR issue number 2 was fixed. It is uncertain how the bots are discovering URLs that are currently WIP and require login to access as they are not discoverable in the app or in the sitemap.
Going forward, we might want to reduce / categorize the logs coming from bots as this is noise which distracts from real issues (structured data fix / memory issue in api)
Expected behavior:
We should no longer get any more errors of "feed not found" when the url contained the improper data type as well as no more memory issues coming from the API
Testing tips:
Go to a gtfs realtime feed page, in the dev.console -> element tab, find the structured data. Looks like this
and assure that the urls in this structured data work and have the proper data type attached
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
closes #66
In our Sentry / Vercel logs, we are getting a lot of
Error: {"detail":/// not foudnAfter investigation the reasons we get this error are
In this PR issue number 2 was fixed. It is uncertain how the bots are discovering URLs that are currently WIP and require login to access as they are not discoverable in the app or in the sitemap.
Going forward, we might want to reduce / categorize the logs coming from bots as this is noise which distracts from real issues (structured data fix / memory issue in api)
Expected behavior:
We should no longer get any more errors of "feed not found" when the url contained the improper data type as well as no more memory issues coming from the API
Testing tips:
Go to a gtfs realtime feed page, in the dev.console -> element tab, find the structured data. Looks like this
and assure that the urls in this structured data work and have the proper data type attached
Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything