You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces the UI elements for the upcoming Notification feature. It is all done with mock data, and there will be follow up tickets for API integration
Subscribe to Notification button + management in Feed Detail Page
New account page layout -> Unlocks future settings to add
Notification settings page + settings dialog
Expected behavior:
Feed Detail Page
Non Authenticated
Subscribe button still shows
When clicked it will prompt the user to sign in
When the user signs in using that button from the popover it will bring them back to the given page
Authenticated
User will be able to click on the subscribe button
At that point the button will turn into a subscribe management button where the user can unsubscribe
The user will be able to modify the global notification settings
Account Page
General and API access is content that existed
The new notification settings tab, the user can view their notifications, and data. They can also manage their notifications by pausing / unsubscribing
** Design Notes **
The UI was build with the assumption of MVP that there will only be 1 global notification setting and the user will not be able to customize the notification per feed
The settings displayed are also examples of what settings can be modified, this is subject to change based on the API implementation capabilities
Testing tips:
In non-authenticated state, go to a feed detail page and try subscribing to the feed
Sign-in then try subscribing
Manage the subscription
Go to the new Account page and play around there
Also test on mobile
Future Follow-up Tickets
Once we get user feedback and make the adjustments
Adjust the settings page based on what we’ll be able to modify (global or per feed)
Integrate the real API
Integrate tests
Place the rest of the i18n translations
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
This might not be in the scope of the mock UI: When the user is not authenticated and clicks the sign-in button in the subscribe action. After successful authentication, it is properly redirected to the feed summary page, but a few seconds later, it is redirected to the account summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
closes #137
This PR introduces the UI elements for the upcoming Notification feature. It is all done with mock data, and there will be follow up tickets for API integration
Expected behavior:
Feed Detail Page
Non Authenticated
Authenticated
Account Page
** Design Notes **
Testing tips:
In non-authenticated state, go to a feed detail page and try subscribing to the feed
Sign-in then try subscribing
Manage the subscription
Go to the new Account page and play around there
Future Follow-up Tickets
Once we get user feedback and make the adjustments
Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything