Skip to content

Address lingering issues from peer review#95

Merged
JIMonroe merged 8 commits intomasterfrom
peer_review
Nov 6, 2018
Merged

Address lingering issues from peer review#95
JIMonroe merged 8 commits intomasterfrom
peer_review

Conversation

@davidlmobley
Copy link
Copy Markdown
Member

@davidlmobley davidlmobley commented Nov 6, 2018

This addresses the remaining issues from peer review from this comment, except for the figure change we need Samarjeet for.

This- Clarified issue about entropy mattering not just for free energies

  • Address what scaling means for barostats
  • Address whether Langevin reduces to Andersen when there is no damping
  • Addresses semigrand ensemble

@davidlmobley davidlmobley changed the title [WIP] Address lingering issues from peer review Address lingering issues from peer review Nov 6, 2018
@davidlmobley
Copy link
Copy Markdown
Member Author

@justinGilmer or @JIMonroe ready for review/merge I think.

@JIMonroe JIMonroe merged commit 592b57e into master Nov 6, 2018
@JIMonroe
Copy link
Copy Markdown
Collaborator

JIMonroe commented Nov 6, 2018

Looks good to go!

@davidlmobley davidlmobley deleted the peer_review branch November 7, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants