[WIP] Remote connection#722
Conversation
|
We make a big test today connecting 7-8 people with different kind of computer. |
cor3ntin
force-pushed
the
remote_connection
branch
from
3cd3f3f to
12b16f5
Compare
The TDM generates a random password (6 alpha numeric characters) that is displayed in the interface of the localhost Launcher, and broadcasted on the local network via zeroconf. In effect this password is only yused by clients outside of the local network. The UI of the launcher is modified to add a password field. Studio and VPL classic are modified to read the password from the command line. The JS api is modified to take a password a parameter, in addition of the endpoint url. createClient(url) becomes createClient(urlm, password) Scratch, VPL3 and Blockly are NOT modified and need to be adapted.
cor3ntin
force-pushed
the
remote_connection
branch
from
12b16f5 to
67d9700
Compare
|
@mbonani I added password support here cor3ntin@67d9700 Let me know what you think |
|
My idea about password was needet for incomming connection outside the local netwrok, but I see now that the password is needet for local network and the password is tranmited by Bonjour. So a actual Thymio Suite 2.2.0 (specially on tablett) will no more work with this new version. Is it possible to distinguish incomming connection from ouside or inside local network? |
|
otherwise form a user point of view I will not show the "password" in the first page and the IP address (that not work on windows but on mac and linux) to connect in the "connection window". Both has to be at same locations. |
|
point decided offline:
|
|
To avoid double work I will prepare the checkbox and move the password |
cor3ntin
force-pushed
the
remote_connection
branch
from
5cec3d6 to
224aaf9
Compare
Because launching a bundle has no support for arguments, we used an url instead. This alternative merchanism to launch an application did not have support for the new parameters (endpoint & password) We modify the mac-specific code to support any argument, then wire the new parameters in the Qt applications.
cor3ntin
force-pushed
the
remote_connection
branch
from
224aaf9 to
66f8356
Compare
|
@mbonani remote connection works on mac now. |
The TDM always tries to initiate a connection to the local server, so that if zero conf is not working ( server disabled, port blocked, etc), everything can still works on the local machine.
cor3ntin
force-pushed
the
remote_connection
branch
3 times, most recently
from
6a647cf to
d4427e9
Compare
|
mac connection working for VPL and Aseba |
|
latest builld TDM is crashing directly on windows: and crash |
|
@mbonani I know, looking into it :) |
Clients from the same subnet can connect to the TDM without password. The password is no longer broadcasted on zeroconf
* Sometimes the TDM would generate an empty password because of incorrect generation code. * Sometimes the client would not receive the password due to the UI not refreshing
cor3ntin
force-pushed
the
remote_connection
branch
from
0b09389 to
ea589d5
Compare
|
|
cor3ntin
force-pushed
the
remote_connection
branch
from
22b7631 to
dc62188
Compare
…into remote_connection
|
runtime 5.15 do not resolve password display issue |
|
connections to remote do not work for webbased |
|
file:///C:/Program%20Files/Thymio/thymio_blockly/thymio_blockly.fr.html#device=%7B177cf107-e5a0-46d5-aa69-ecfd18fb9cac%7D&ws=ws://85.90.23.32:8597&pass=TR2LUY |
|
for the password I just see in real time the password that is shown and then disapear... |
|
2021-09-08 18:28:36.705] [console] [info] fw_update_service.cp@L58: Downloading https://www.mobsya.org//update/Thymio2-firmware-meta.xml here is trace of TDM, I see nothing |
There were a few issues: * The launcher was still trying to read the password out of the zeroconf record. Because this is no longer broadcasted by the TDM, the password was always set to empty once a discovery record was found. * The signal that a local connection was established before the endpoint was fully registered.
|
password fixed |
|
I confirm that blockly or scratch do not connect to remote TDM someting aroud thymio.js:line505 on flexbuffer is wrong |
|
@mbonani I have no issue. |
|
@mbonani Yep, i did a lot of tests on different machines. Blockly works. in the last CI package |
|
Yes for scratch I merge your PR and packet is build automatically, I put it manually in my installation on windows (I often do it for trying ) On my windows connecting to Linux, when it is with a remote host it fails both on scratch and blockly at the same point: thymio.js line 505. Same from Mac with Blockly. And i see nothing on log of TDM on the Linux like it receive no connection. |
|
browser.js:14 file:///C:/Program%20Files/Thymio/thymio_blockly/thymio_blockly.fr.html#device=%7B35c5cc80-426f-417a-8976-e855f2306c3a%7D&ws=ws://85.90.23.32:8597&pass=LUZVV6 logs from Blockly |
This reverts commit 58716bc.
3 participants
No description provided.