Improve zero conf announce reliability.#944
Merged
mbonani merged 2 commits intoMobsya:masterfrom Sep 2, 2021
Merged
Conversation
* Make sure the even loop was entered before trying to announce the TDM on zeron conf. * Make sure the server are accepting connections by the TDM is announced on zero conf. * Refresh the announce every few seconds in case there was some spurious failure. This changes should make zero conf a bit more reliable and avoid some of the issues where the launcher doesn't see the TDM
cor3ntin
force-pushed
the
add_zeroconf_timer2
branch
from
5eec273 to
90bca0d
Compare
Contributor
|
bug of not correct annoncement is still there on my Linux : |
Contributor
Contributor
Author
|
See Mobsya/aware#1 for #871 |
Contributor
|
#871 is fixed |
Contributor
Author
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the even loop was entered before trying to announce
the TDM on zeroconf.
Make sure the server are accepting connections by the TDM is
announced on zero conf.
Refresh the announce every few seconds in case there
was some spurious failure.
This changes should make zero conf a bit more reliable and
avoid some of the issues where the launcher doesn't see the
TDM
I have spend a significant amount of time trying to find race conditions, undefined behavior and so forth and I am not seeing anything abnormal.
I have compared aware with other zero conf implementations ( notably the one used by the launcher) and I'm not seeing anything weird.
There was an issue where we could try to announce on zero conf before the client was started if the event loop had not been started yet. I am assuming this was the culprit.
This patch should allow the TDM to announce itself if for some reason (which i was not able to really reproduce), it fails the first time.
This, along with further patches to enable direct connection to local TDM will hopefully reduce the number of issues observed by users