Conversation
Perryvw
reviewed
Feb 6, 2020
| if (unit.IsRealHero()) { | ||
| Timers.CreateTimer(1, () => { | ||
| unit.AddNewModifier(undefined, undefined, "modifier_panic", { duration: 8 }); | ||
| modifier_panic.apply(unit, undefined, undefined, { duration: 8 }); |
Member
There was a problem hiding this comment.
I think this is a nice way of doing this, but I think we should stick to the original API for this. Advanced users can come up with this themself or maybe read it somewhere else.
| import { BaseAbility, registerAbility } from "../../../lib/dota_ts_adapter"; | ||
|
|
||
| @luaAbility | ||
| class meepo_earthbind_ts_example extends CDOTA_Ability_Lua { |
Member
There was a problem hiding this comment.
Not sure about this change. I already don't like how un-transparent this is, and I don't think this really helps.
Perryvw
reviewed
May 30, 2020
| @luaAbility | ||
| class meepo_earthbind_ts_example extends CDOTA_Ability_Lua { | ||
| @registerAbility("meepo_earthbind_ts_example") | ||
| export class meepo_earthbind_ts_example extends BaseAbility { |
Member
There was a problem hiding this comment.
So we can also remove BaseAbility?
Perryvw
reviewed
May 30, 2020
| } | ||
|
|
||
| const [env, source] = getFileScope(); | ||
| const [fileName] = string.gsub(source, ".*scripts[\\/]vscripts[\\/]", ""); |
Member
There was a problem hiding this comment.
I think this is even more intransparant, I prefer the name as string parameter to the decorator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.