Skip to content
This repository was archived by the owner on Dec 30, 2022. It is now read-only.

Text adjustments to better match the size of the buttons#57

Merged
DeathsGun merged 1 commit intoModManagerMC:1.17from
Felix14-v2:patch-2
Sep 20, 2021
Merged

Text adjustments to better match the size of the buttons#57
DeathsGun merged 1 commit intoModManagerMC:1.17from
Felix14-v2:patch-2

Conversation

@Felix14-v2
Copy link
Copy Markdown
Contributor

Although, even this is not enough.
image

I think this is the final translation for the new version.

@DeathsGun
Copy link
Copy Markdown
Member

I can also make the sorting button bigger

@Felix14-v2
Copy link
Copy Markdown
Contributor Author

That would be nice.
Even better, if the size was adjusted to the length of the text.

@DeathsGun
Copy link
Copy Markdown
Member

I have adjusted the button size then this shouldn’t be necessary or not?

@Felix14-v2
Copy link
Copy Markdown
Contributor Author

Felix14-v2 commented Sep 19, 2021

I think now the text will not go beyond the borders of the buttons.
This PR also includes some improvements to a previously untested strings. If you want, I can return the previous versions of abbreviated translations, but keep the improvements.

@DeathsGun DeathsGun merged commit 1d293c8 into ModManagerMC:1.17 Sep 20, 2021
@github-actions
Copy link
Copy Markdown

Unit Test Results

1 files  ±0  1 suites  ±0   1s ⏱️ ±0s
6 tests ±0  6 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1d293c8. ± Comparison against base commit 1d293c8.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants