Don't apply LOOT-sorted load order until user clicks "Apply"#2382
Open
JonathanFeenstra wants to merge 1 commit intoModOrganizer2:masterfrom
Open
Don't apply LOOT-sorted load order until user clicks "Apply"#2382JonathanFeenstra wants to merge 1 commit intoModOrganizer2:masterfrom
JonathanFeenstra wants to merge 1 commit intoModOrganizer2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the LOOT sort dialog behavior to not immediately apply the sorted load order, but wait until the user clicks the "Apply" button (instead of just having a "Close" button, I changed it to "Apply" and "Cancel" buttons). The "Are you sure you want to sort your plugins list?" message box is now only shown if MO2 is in offline mode, since the user can already cancel the sort and now still has the opportunity to cancel even after the sorting is done.
Requires ModOrganizer2/modorganizer-lootcli#31