Skip to content

Fix Pre-LN for GPT2 Model#136

Merged
le1nux merged 1 commit intodev_experimentsfrom
fix/pre-ln
May 27, 2024
Merged

Fix Pre-LN for GPT2 Model#136
le1nux merged 1 commit intodev_experimentsfrom
fix/pre-ln

Conversation

@flxst
Copy link
Copy Markdown
Member

@flxst flxst commented May 23, 2024

This PR fixes the pre-LN by reverting the changes (accidentally?) introduced here

References:

@flxst flxst requested a review from le1nux May 27, 2024 07:10
@le1nux le1nux changed the base branch from main to dev_experiments May 27, 2024 09:56
Copy link
Copy Markdown
Member

@le1nux le1nux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good find!

@le1nux le1nux merged commit bc3e9a9 into dev_experiments May 27, 2024
@le1nux le1nux added bug Something isn't working enhancement New feature or request labels May 27, 2024
@le1nux le1nux deleted the fix/pre-ln branch May 27, 2024 09:59
@le1nux le1nux removed the enhancement New feature or request label May 27, 2024
@le1nux le1nux mentioned this pull request Jun 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants