Skip to content

Unified unit & end-to-end testing#155

Merged
flxst merged 24 commits intodev_experimentsfrom
feat/unified-testing
Jun 19, 2024
Merged

Unified unit & end-to-end testing#155
flxst merged 24 commits intodev_experimentsfrom
feat/unified-testing

Conversation

@flxst
Copy link
Copy Markdown
Member

@flxst flxst commented Jun 13, 2024

This PR

  • introduces a new script tests/tests.py, which can be used for both unit and end-to-end testing. (6101bb9, 81cacfa, 74045d8, e0d0a42, 563cf27)

    Examples:

    • python tests/tests.py: run CPU tests + single-GPU tests on GPU 0 + multi-GPU tests on GPUs 0/1
    • python tests/tests.py --devices 4,5: same as above but using devices 4/5
    • python tests/tests.py --cpu: run CPU tests
    • python tests/tests.py --single-gpu --devices 3: run CPU tests + single-GPU tests on GPU 3
    • python tests/tests.py --multi-gpu --devices 3,4: run multi-GPU tests on GPUs 3/4

    Note that any GPU device 0-7 can be specified.

  • fixes some unit test minor issues (6c4e0f4, 5d2cd14)

  • fixes all end-to-end tests (all other commits)

@flxst flxst self-assigned this Jun 13, 2024
@flxst flxst marked this pull request as draft June 13, 2024 13:56
Comment thread src/modalities/__main__.py Outdated
Comment thread src/modalities/__main__.py Outdated
Comment thread src/modalities/__main__.py Outdated
Comment thread src/modalities/__main__.py Outdated
Comment thread src/modalities/__main__.py Outdated
Comment thread src/modalities/__main__.py Outdated
Comment thread tests/test_optimizer_factory.py
@flxst flxst requested review from fromm-m and le1nux June 18, 2024 15:22
@flxst flxst marked this pull request as ready for review June 18, 2024 15:22
@fromm-m
Copy link
Copy Markdown
Member

fromm-m commented Jun 19, 2024

We should add the pip packaging to pyproject.toml and run once the git pre-commit hooks so that the actions run through, beside that it can be merged.

@flxst
Copy link
Copy Markdown
Member Author

flxst commented Jun 19, 2024

We should add the pip packaging to pyproject.toml and run once the git pre-commit hooks so that the actions run through, beside that it can be merged.

Will be done as part of #157.

@flxst flxst merged commit f05eef5 into dev_experiments Jun 19, 2024
@flxst flxst deleted the feat/unified-testing branch June 19, 2024 08:44
@le1nux le1nux mentioned this pull request Jun 19, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants