bug fix: Enforce power of 2 number of bytes per token #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, the number of bytes per token was calculated by
math.ceil(log_2(vocab_size)/8), leading to ranges between 1 and 4 bytes.However, the dataset implementation only support 1, 2 and 4 bytes per token, as defined here
modalities/src/modalities/dataloader/dataset.py
Lines 202 to 206 in 0483362
and
modalities/src/modalities/dataloader/dataset.py
Lines 233 to 234 in 0483362
I added a switch case that maps to the respective byte sizes, when packing the data.
This adds some inefficiencies as a vobabulary size > 65536 already requires 4 bytes per token, effectively doubling the storage requirements.
Checklist before submitting final PR
python tests/tests.py)CHANGELOG_DEV.md)