Skip to content

feat: Make RoPE Base Frequency Configurable #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
le1nux merged 1 commit into from
Jan 31, 2025
Merged

feat: Make RoPE Base Frequency Configurable #297

le1nux merged 1 commit into from
Jan 31, 2025

Conversation

@mali-git
Copy link
Member

@mali-git mali-git commented Jan 30, 2025

What does this PR do?

This PR ..

General Changes

  • ..

Breaking Changes

  • ..

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)

@mali-git mali-git requested review from fromm-m and le1nux January 30, 2025 17:39
le1nux
le1nux approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@le1nux le1nux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :-)

fromm-m
fromm-m approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@fromm-m fromm-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@le1nux le1nux merged commit 7bbad67 into main Jan 31, 2025
3 of 5 checks passed
@le1nux le1nux deleted the make_rope_base_freq_configurable branch January 31, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@le1nux le1nux le1nux approved these changes

@fromm-m fromm-m fromm-m approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mali-git @le1nux @fromm-m