Skip to content

Fsdp2 lr scheduler integration #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
le1nux merged 13 commits into from
Mar 11, 2025
Merged

Fsdp2 lr scheduler integration #316

le1nux merged 13 commits into from
Mar 11, 2025

Conversation

@le1nux
Copy link
Member

@le1nux le1nux commented Mar 10, 2025

What does this PR do?

This PR ..

General Changes

  • ..

Breaking Changes

  • ..

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)
  • I have updated the internal changelog (CHANGELOG_DEV.md)

@le1nux le1nux merged commit bea18c4 into fsdp2_min_integration Mar 11, 2025
3 checks passed
@le1nux le1nux deleted the fsdp2_lr_scheduler_integration branch March 11, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@le1nux