Skip to content

feat: disentagle model and optimizer checkpoint loading #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mali-git merged 1 commit into from
Mar 12, 2025
Merged

feat: disentagle model and optimizer checkpoint loading #318

mali-git merged 1 commit into from
Mar 12, 2025

Conversation

@mali-git
Copy link
Member

@mali-git mali-git commented Mar 12, 2025

What does this PR do?

This PR ..

General Changes

  • ..

Breaking Changes

  • ..

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)
  • I have updated the internal changelog (CHANGELOG_DEV.md)

@fromm-m fromm-m self-requested a review March 12, 2025 13:53
fromm-m
fromm-m approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@fromm-m fromm-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mali-git mali-git merged commit 5525864 into main Mar 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fromm-m fromm-m fromm-m approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mali-git @fromm-m