Error building spi example xpt2046 for esp32/m5atom_matrix

[louisvangeldrop]

Build environment: Windows
Moddable SDK version: 7.2.1
Target device: esp32/m5atom_matrix

Description
A brief summary of the problem

Steps to Reproduce

1. Build and install the app using this build command: mcconfig -m -d -p esp32/m5atom_matrix
2. Error

# cc spi.c.o
In file included from C:\Users\louis\projecten\moddable\modules\io\spi\esp32\spi.c:4:                                                 
C:/Users/louis/projecten/moddable/modules/io/spi/esp/spi.c: In function 'xs_spi_constructor':                                         
C:/Users/louis/projecten/moddable/modules/io/spi/esp/spi.c:134:14: error: 'SPI_HOST' undeclared (first use in this function); did you mean 'SPI3_HOST'?                                                                                                                     
  134 |         if ((SPI_HOST != tmp) && (SPI2_HOST != tmp)                                                                           
      |              ^~~~~~~~                                                                                                         
      |              SPI3_HOST                                                                                                        
C:/Users/louis/projecten/moddable/modules/io/spi/esp/spi.c:134:14: note: each undeclared identifier is reported only once for each function it appears in
NMAKE : fatal error U1077: 

[phoddie]

It looks like line 134 above should be:

if ((SPI1_HOST != tmp) && (SPI2_HOST != tmp)

Espressif has been renaming the native SPI constants. Tough to keep up...

Please give that a try and let me know if it helps. Thanks!

[louisvangeldrop]

Your suggestion solved the problem. Thank you for the quick response.
Actually I am using a DOIT esp32 Devkit V1, which is not specified in the targets.

[phoddie]

Your suggestion solved the problem. Thank you for the quick response.

Excellent. We'll integrate that change for our April release.

Actually I am using a DOIT esp32 Devkit V1, which is not specified in the targets.

Nice. Once you've got a working target, a PR would be welcome.

[louisvangeldrop]

Now I can control my SOMFY RTS shutters with Moddable. See: https://github.com/louisvangeldrop/somfy.

[phoddie]

Very cool! Thanks for publishing that example. Very nice piece of work.

I notice that you bounced between C and JavaScript implementations of the digital pulse code, and settled on JavaScript. For precise timing, C will be better, of course. There's actually a way to call the ECMA-419 digital implementation directly from C, instead of having to call back through JavaScript write(). If you are interested, let me know and I'll put together some notes. Maybe JavaScript is fast enough here, so there's no need.

Otherwise... if it isn't too much trouble, it would be wonderful to have a small demo video. We'd like to share this on our social media challenge and having a demo would give it more impact.

[louisvangeldrop]

I strongly believe that anything I can do in JavaScript should be implemented in JavaScript, unless C++ is required for performance reasons. Up until now, Moddable has been fast enough for everything I need, with the exception of handling interrupts with debouncing.

Any suggestions what to show at the video?

[phoddie]

I strongly believe that anything I can do in JavaScript should be implemented in JavaScript

❤️

Up until now, Moddable has been fast enough for everything I need, with the exception of handling interrupts with debouncing.

That's so great to hear.

The reason I asked was a concern that perhaps the timing with the JavaScript spin loop wasn't quite accurate enough for your tight timing constraints. But you are right that the overhead isn't really that much, so it should be fine.

Since the virtual machine doesn't run at interrupt time, interrupt handlers are one place where C is inescapable. FWIW, I've had good success using a tiny, dedicated worker thread to minimize the C. The native interrupt handler bounces a message to the worker. Since the worker is dedicated, it is never blocking and can wake up more-or-less immediately to take care of the rest.

Any suggestions what to show at the video?

I don't want to make a bunch of much work for you. You know it best – anything short and clear would be fine. As I understand it, your project is an ESP32 app that is accessibly by its mDNS host name on the local network that controls the shutters. It sounds like you have a web page built around that. What works well is showing the shutters and the control at the same time – the control I suppose can either be raw URLs (e.g. cURL) or your web page. Both are interesting. To show them at the same time, we'll do a screen recording with a camera pointed at the device (shutters) that is shown on your computer screen. That keeps the set-up simple.

[louisvangeldrop]

The digitalPulse.c function is using an mixed array with positive and negative values to pulse the pin. This works very well : [604,-604,-604,604] etc. The digitalPulse.js uses the Espruino definition, starting with a begin state and alternating values. However if I change digitalPulse.js into the same functionality as the digitalPulse.c it fails due to timing errors. So I changed the code and it will use the digitalPulse.c

For the video I will find out how it can be done using Windows

[phoddie]

I guess your digitalPulse module is more-or-less the transmit side of the RMT (that Espressif unfortunately removed...).

For the video I will find out how it can be done using Windows

Cool. Thank you again.