This repository was archived by the owner on Apr 9, 2024. It is now read-only.
Fix crash on difficultyBeatmap nullptr #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
are you sure this actually fixes that crash? isCustom also performs a null check, so it being null would still result in the early return code being ran |
Contributor
Author
|
The IPreviewBeatmapLevel is not null and should never be, which is why it's not being caught |
Collaborator
|
my bad, I thought it added null checking the |
RedBrumbler
approved these changes
Mar 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When joining a lobby in Multiplayer where a map is currently being played that can't be played, for example DLC not being owned, the game sets difficultyBeatmap to nullptr to indicate that the player should be put into spectator with the not owned message.
This fixes the crash that happens with PinkCore trying to access data on a nullptr difficultyBeatmap.