Skip to content

fix fp32 reduce on/off #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

fix fp32 reduce on/off #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions gptqmodel/nn_modules/qlinear/marlin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,6 @@ def get_scale_perms():
return scale_perm, scale_perm_single


# In case there is a performance issue with Marlin, the variable below can be
# changed to False, which allows Marlin to perform global reductions in fp16
# precision (instead of fp32), and therefore, save on some memory movements.
USE_FP32_REDUCE_DEFAULT = True

# Whether to use atomicAdd reduce in gptq/awq marlin kernel. experimental
GPTQMODEL_MARLIN_USE_ATOMIC_ADD = True

Expand Down Expand Up @@ -219,7 +214,7 @@ def apply_gptq_marlin_linear(
input_size_per_partition: int,
is_k_full: bool,
bias: Optional[torch.Tensor] = None,
use_fp32_reduce: bool = USE_FP32_REDUCE_DEFAULT) -> torch.Tensor:
use_fp32_reduce: bool = True) -> torch.Tensor:
reshaped_x = input.reshape(-1, input.shape[-1])
out_shape = input.shape[:-1] + (output_size_per_partition,)

Expand Down Expand Up @@ -538,6 +533,7 @@ def forward(self, x: torch.Tensor):
input_size_per_partition=self.in_features,
is_k_full=self.is_k_full,
bias=self.bias,
use_fp32_reduce=self.fp32,
)

if self.adapter:
Expand Down