fix eora compat #1932
Merged
fix eora compat #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qubitium <Qubitium@modelcloud.ai>
…uted on primary processor lifecycle Signed-off-by: Qubitium <Qubitium@modelcloud.ai>
Collaborator
Author
|
Execution bug/order fixed due to threading scope issues. Offloading bug also fixed. But there is a secondary offloadig bug that appears to breaking lora module save. I will check this a bit later. |
Collaborator
Author
|
Found the save bug. Will fix it soon. The eora needs to join the offload disk life cycle. Right now main enjoys 75%+ cpu memory saving during quant with inline packing and offloading to disk right after processing. eora is missing this bit of logic so need to fix this. |
Signed-off-by: Qubitium <Qubitium@modelcloud.ai>
Signed-off-by: Qubitium <Qubitium@modelcloud.ai>
Collaborator
Author
|
merging. ci runs but the quality is bad (not just eora). But other ci tests don't have this quality issue. not sure what's going on but looks to be this ci test specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nbasyl There is two issues with EoRA and main (lots of refractor and multi-threading changes in prep for pending multi-gpu data parallel inference). You can track this here. I will merge once
test_quant_and_eorapasses ci test.eoraprocessor compateorato fail/crash.