Skip to content

Fix for #2116 When all modules of a layer excluded there is an error in forward replay #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Fix for #2116 When all modules of a layer excluded there is an error in forward replay #2117

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
da463bb
trying marlin for awq
avtc Oct 25, 2025
01c740b
Revert "trying marlin for awq"
avtc Oct 25, 2025
339deb3
fix replay when no modules were quantized in the layer
avtc Oct 25, 2025
7fc2936
debug
avtc Oct 25, 2025
7013698
missing change
avtc Oct 25, 2025
432f78d
remove any_modules_processed
avtc Oct 25, 2025
723973f
fill forward_device_map for any layers not only moe
avtc Oct 25, 2025
b4551f4
revert init of is_moe_layer, forward_device_map, subset_forward_seria…
avtc Oct 26, 2025
30eac6c
remove obsolete comment
avtc Oct 26, 2025
02ac2df
fix newline spaces
avtc Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions gptqmodel/looper/module_looper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,6 +1320,12 @@ def _loop_impl(self, fail_safe: bool = False, **kwargs):
attention_masks = processor.inputs_cache.attention_masks

processed_subset = {}

subset_total = len(modules)
index = 0
subset = {}
forward_device_map: Dict[str, torch.device] = {}
subset_forward_serial = False

for index, names in enumerate(modules):
subset = self.crate_named_modules(full=full, is_lm_head_module=is_lm_head_module,
Expand All @@ -1328,9 +1334,6 @@ def _loop_impl(self, fail_safe: bool = False, **kwargs):
processor=processor,
fail_safe=fail_safe)

if len(subset) == 0:
continue

moe_group_keys_all: List[str] = []
forward_device_map: Dict[str, torch.device] = {}
subset_forward_serial = False
Expand Down Expand Up @@ -1403,7 +1406,6 @@ def _loop_impl(self, fail_safe: bool = False, **kwargs):
setattr(named_module, "moe_enabled", False)

handle = []
subset_total = len(modules)
batch_count = self._resolve_batch_total(
getattr(processor, "num_batches", None),
layer_inputs,
Expand Down