Optional CPU g_idx int64 cache for TorchQuantLinear dequant path#2431
Merged
Optional CPU g_idx int64 cache for TorchQuantLinear dequant path#2431
CPU g_idx int64 cache for TorchQuantLinear dequant path#2431Conversation
Reuse a cached int64 g_idx tensor in the non-Triton GPTQ torch dequant path to avoid repeated int32->int64 conversion and indexing overhead. Observed speedups (dequant microbench): - up to ~24% on Zen3 CPU - up to ~13% on A100 in non-Triton mode - up to ~5% on 4090 in non-Triton mode Memory cost: - additional cache per module: numel(g_idx) * 8 bytes (int64)
CPU g_idx int64 cache for TorchQuantLinear dequant path
Changed from column-only slicing to aligned row+column block slicing in the num_itr > 1 branch. 2. Fixed the same bug in cached torch path (_dequantize_weight_cached_248)
Collaborator
Author
|
128 core Zen3, sweet spot is 16 threads |
Collaborator
Author
|
Dequant performance is already sub ms on gpu so the improvement is much smaller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse a cached int64 g_idx tensor in the non-Triton GPTQ torch dequant path to avoid repeated int32->int64 conversion and indexing overhead.
Observed speedups (dequant microbench):
Memory cost:
Disable by default as microbenchs shows only big gain on cpu and cpu specific thread size. 21% is a pretty good boost.