Skip to content

[app-builder] bugfix: inherit guest setting every time app published #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

[app-builder] bugfix: inherit guest setting every time app published #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...s/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/domains/appversion/AppVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ public class AppVersion {
private static final Logger LOGGER = Logger.get(AppVersion.class);
private static final String PUBLISH_UPDATE_DESCRIPTION_KEY = "publishedDescription";
private static final String PUBLISH_UPDATE_LOG_KEY = "publishedUpdateLog";
private static final String ALLOW_GUEST = "allow_guest";
private static final int RETRY_PATH_GENERATION_TIMES = 3;
private static final int PATH_LENGTH = 16;
private static final String VERSION_FORMAT = "{0}.{1}.{2}";
Expand Down Expand Up @@ -748,11 +749,13 @@ public void cloneVersion(AppBuilderAppCreateDto dto, String version, String type
this.getFormProperties().forEach(p -> p.setAppId(newAppId));

if (Objects.nonNull(dto)) {
boolean allowGuest = ObjectUtils.cast(this.attributes.getOrDefault(ALLOW_GUEST, false));
this.attributes.clear();
this.attributes.put("description", dto.getDescription());
this.attributes.put("icon", dto.getIcon());
this.attributes.put("greeting", dto.getGreeting());
this.attributes.put("app_type", dto.getAppType());
this.attributes.put(ALLOW_GUEST, allowGuest);
if (StringUtils.isNotBlank(dto.getStoreId())) {
this.attributes.put("store_id", dto.getStoreId());
this.data.setUniqueName(dto.getStoreId());
Expand Down