🐛 Bugfix: Enhance ToolTestPanel to support dynamic KB selection based on tool type#2868
Merged
🐛 Bugfix: Enhance ToolTestPanel to support dynamic KB selection based on tool type#2868
Conversation
* Introduced kbSelectionConfig to manage knowledge base selection parameters. * Updated logic to determine parameter names for different tool types. * Merged KB selection configuration into final tool parameters to streamline processing.
Zhi-a
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ToolTestPanel so knowledge base (KB) selection is passed as an init-time tool configuration parameter, with the KB parameter name chosen dynamically based on tool type (e.g., dataset_ids for Dify vs index_names for other KB-backed tools). This aligns the test/validation flow with how backend tools are instantiated during /tool/validate.
Changes:
- Added
kbSelectionConfigto represent KB selection as tool init params rather than forward inputs. - Selected KB parameter key dynamically (
dataset_idsfordify_search, otherwiseindex_names). - Merged KB selection config into the final
configspayload sent tovalidateTool.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+324
to
+330
| // Determine the correct parameter name based on tool type | ||
| if (tool?.name === "dify_search") { | ||
| kbSelectionConfig = { dataset_ids: JSON.stringify(selectedKbIds) }; | ||
| } else { | ||
| // knowledge_base_search, datamate_search, idata_search use index_names | ||
| kbSelectionConfig = { index_names: selectedKbIds }; | ||
| } |
Dallas98
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance ToolTestPanel to support dynamic KB selection based on tool type