Skip to content

[Fix] Only mark last req as failed load req #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

[Fix] Only mark last req as failed load req #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ucm/integration/vllm/uc_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def start_load_kv(self, forward_context: "ForwardContext", **kwargs) -> None:

self.layerwise_load_tasks.clear()
self.current_layer = 0
need_wait_tasks = []
need_load_tasks: dict[str, Task] = {}
for request in metadata.requests:
if not request.load_blocks:
continue
Expand Down Expand Up @@ -295,10 +295,11 @@ def start_load_kv(self, forward_context: "ForwardContext", **kwargs) -> None:
if is_load_async:
self._need_load_reqs[request.request_id] = task_id
else:
need_wait_tasks.append(task_id)
for task_id in need_wait_tasks:
need_load_tasks[request.request_id] = task_id
for req_id, task_id in need_load_tasks.items():
if self.connector.wait(task_id) != 0:
self._load_failed_reqs.add(request.request_id)
self._load_failed_reqs.add(req_id)
logger.error(f"Failed to load blocks for req {req_id}")

def wait_for_layer_load(self, layer_name: str) -> None:
"""
Expand Down