[bugfix] add cmake option to bypass NUMA binding #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarence-1103
requested review from
FangRun2,
Tarrei,
hek14,
leideng,
mag1c-h,
pengwwang,
saki-daisuki,
summer-ai007,
wangwenxin0312,
wuhuxiao,
xwLearnsLLM and
ygwpz
as code owners
Contributor
|
pr title should be like [bugfix]xxx |
mag1c-h
reviewed
Nov 18, 2025
Clarence-1103
force-pushed
the
check_esa
branch
from
5e50150 to
d3414a7
Compare
Clarence-1103
changed the title
hek14
approved these changes
Nov 19, 2025
wangwenxin0312
approved these changes
Nov 19, 2025
ygwpz
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What this PR does / why we need it?
fix cmake NUMA_ENABLED
Modifications
Does this PR introduce any user-facing change?
Add a compilation switch to decide whether to compile NUMA.
Test
1.pip install -v -e. --no-build-isolation
2.cmake -DRUNTIME_ENVIRONMENT=cuda -DBUILD_NUMA=ON ..
How was this patch tested?