Skip to content

[bugfix] The Metrics module uses a non-existent variable self.rank #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

[bugfix] The Metrics module uses a non-existent variable self.rank #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/ucm_config_example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ ucm_connectors:

load_only_first_rank: false

metrics_config_path: "/vllm-workspace/metrics_config.yaml"
# Enable UCM metrics so they can be monitored online via Grafana and Prometheus.
# metrics_config_path: "/workspace/unified-cache-management/examples/metrics/metrics_configs.yaml"

# Sparse attention configuration
# Format 1: Dictionary format (for methods like ESA, KvComp)
Expand Down
2 changes: 1 addition & 1 deletion ucm/integration/vllm/ucm_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def __init__(self, vllm_config: "VllmConfig", role: KVConnectorRole):
if self.metrics_config:
self.stats_logger = UCMStatsLogger(
vllm_config.model_config.served_model_name,
self.rank,
self.global_rank,
self.metrics_config,
)
self.monitor = ucmmonitor.StatsMonitor.get_instance()
Expand Down