Skip to content

Conversation

@mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Mar 31, 2023

This PR

  • adds Przemek as contributor,
  • changes David Watson from contributor to author. He added parallel implementation, and even more important the ingrediences to handle the exact case efficiently
  • prevents verbose = FALSE to hide warnings

As such, it is the next CRAN candidate

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #83 (842c6fa) into main (edcbd02) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 842c6fa differs from pull request most recent head 45d0308. Consider uploading reports for the commit 45d0308 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files           5        5           
  Lines         346      346           
=======================================
  Hits          324      324           
  Misses         22       22           
Impacted Files Coverage Δ
R/kernelshap.R 99.05% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mayer79
Copy link
Collaborator Author

mayer79 commented Mar 31, 2023

Accepted

@mayer79 mayer79 merged commit a131854 into main Mar 31, 2023
@mayer79 mayer79 deleted the cran_subm branch March 31, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants