Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the /v1/models endpoint and enables support for multiple choices (n > 1) in streaming chat and completion APIs. Key changes include the addition of a --model_owner CLI argument, the definition of ModelCard and ModelListResponse schemas, and a refactor of the streaming logic to correctly handle choice indices and tool call states. A review comment identifies an unused raw_request parameter in the new get_models endpoint.
|
|
||
| @app.get("/v1/models", response_model=ModelListResponse) | ||
| @app.post("/v1/models", response_model=ModelListResponse) | ||
| async def get_models(raw_request: Request): |
Contributor
There was a problem hiding this comment.
The raw_request parameter is unused in the get_models function and can be removed to improve code clarity.
Suggested change
| async def get_models(raw_request: Request): | |
| async def get_models(): |
shihaobai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.