fix: typo prefll -> prefill in cudagraph option#1283
Merged
Conversation
…x_handle_token Fix typo "prefll" -> "prefill" in the prefill cudagraph option name and the corresponding code/comment references.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects several instances of the typo 'prefll' to 'prefill' across multiple files, including comments, variable names, command-line arguments, and data structures related to CUDA graph prefilling. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--prefll_cudagraph_max_handle_tokento--prefill_cudagraph_max_handle_tokenand update the matchingstart_args_typefield and consumer inprefill_cuda_graph.py.infer_struct.py(prefll cuda graph->prefill cuda graph).Test plan
python -m lightllm.server.api_cli --help | grep prefill_cudagraph_max_handle_tokenshows the renamed flag.--prefill_cudagraph_max_handle_token 512and confirm prefill cudagraph still initializes.