Skip to content

add wan22 animate 8gpu config#600

Merged
helloyongyang merged 1 commit intoModelTC:mainfrom
black-eleven:deploy-animate
Dec 11, 2025
Merged

add wan22 animate 8gpu config#600
helloyongyang merged 1 commit intoModelTC:mainfrom
black-eleven:deploy-animate

Conversation

@black-eleven
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @black-eleven, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a specialized configuration file for the wan22 animation model, tailored for high-performance environments leveraging 8 GPUs. The new configuration integrates flash_attn3 across various attention types and defines specific parallel processing parameters, aiming to optimize the efficiency and scalability of video generation tasks on multi-GPU systems.

Highlights

  • New Configuration File: A new configuration file, wan_animate_8gpu.json, has been added under the configs/wan22/ directory.
  • 8-GPU Optimization: This configuration is specifically designed for animating with an 8-GPU setup, indicating a focus on distributed processing.
  • Flash Attention 3 Integration: The configuration extensively utilizes flash_attn3 for self_attn_1_type, cross_attn_1_type, cross_attn_2_type, and adapter_attn_type, suggesting performance optimization for attention mechanisms.
  • Parallel Processing Settings: It includes parallel processing settings with seq_p_size set to 8 and seq_p_attn_type as ulysses, further enhancing multi-GPU efficiency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configuration file for running the wan22 animate model on an 8-GPU setup. The new config, wan_animate_8gpu.json, correctly enables 8-way sequence parallelism by adding a parallel block to the base wan_animate.json settings. The change is correct and follows existing patterns. For future maintainability, consider implementing a config inheritance system to reduce duplication between configuration files like this one.

@helloyongyang helloyongyang merged commit a2237f2 into ModelTC:main Dec 11, 2025
1 check passed
@black-eleven black-eleven deleted the deploy-animate branch December 11, 2025 06:29
helloyongyang pushed a commit that referenced this pull request Mar 6, 2026
Co-authored-by: yihuiwen <yihuiwen@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants