Skip to content

Move va_xxx.py to lightx2v/utils/#928

Merged
helloyongyang merged 1 commit intoModelTC:mainfrom
huochaitiantang:mv_va
Mar 6, 2026
Merged

Move va_xxx.py to lightx2v/utils/#928
helloyongyang merged 1 commit intoModelTC:mainfrom
huochaitiantang:mv_va

Conversation

@huochaitiantang
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the project's internal structure by relocating a set of video and audio utility modules. By moving these common helper files from the deploy/common directory to a dedicated utils directory, the change enhances code organization and maintainability. This refactoring ensures that utility functions are centralized, leading to a clearer separation of concerns and a more logical project layout.

Highlights

  • File Relocation: Several utility files related to video and audio processing (e.g., va_controller.py, va_reader.py, video_recorder.py) have been moved from lightx2v/deploy/common/ to lightx2v/utils/.
  • Import Path Updates: All affected files, including parallel_model_runner.py, wan_audio_runner.py, and wan_sf_runner.py, have had their import statements updated to reflect the new location of these utility modules.
  • Internal Import Adjustments: The va_controller.py file, after being moved, also had its internal relative imports adjusted to correctly reference other va_xxx modules within the new lightx2v/utils/ directory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • lightx2v/deploy/common/va_controller.py
    • Renamed to lightx2v/utils/va_controller.py.
    • Updated internal imports to reflect new utility module paths.
  • lightx2v/deploy/common/va_reader.py
    • Renamed to lightx2v/utils/va_reader.py.
  • lightx2v/deploy/common/va_reader_omni.py
    • Renamed to lightx2v/utils/va_reader_omni.py.
  • lightx2v/deploy/common/va_recorder.py
    • Renamed to lightx2v/utils/va_recorder.py.
  • lightx2v/deploy/common/va_recorder_x264.py
    • Renamed to lightx2v/utils/va_recorder_x264.py.
  • lightx2v/deploy/common/video_recorder.py
    • Renamed to lightx2v/utils/video_recorder.py.
  • lightx2v/deploy/worker/parallel_model_runner.py
    • Updated import path for VAController.
  • lightx2v/models/runners/wan/wan_audio_runner.py
    • Updated import path for VAController.
  • lightx2v/models/runners/wan/wan_sf_runner.py
    • Updated import path for VideoRecorder.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily refactors the codebase by moving several va_*.py modules from lightx2v/deploy/common/ to lightx2v/utils/. The changes are mostly file moves and corresponding import path updates. The refactoring is clean, but I've identified an opportunity to improve the import style in va_controller.py by moving local imports to the top of the file.

@helloyongyang helloyongyang merged commit dd9b3e8 into ModelTC:main Mar 6, 2026
1 check passed
helloyongyang pushed a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants