Add temporary builds from GitHub Actions#365
Merged
skejserjensen merged 11 commits intomainfrom Nov 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds automated binary builds for aarch64 macOS, x86_64 Windows, and x86_64 Linux on every commit to the main branch, making development builds available as GitHub Actions artifacts for 90 days. The workflow has been enhanced and streamlined, and documentation has been added to inform users how to access these builds.
- Adds a new
build_and_upload_binariesjob to the GitHub Actions workflow that builds and uploads binaries after successful testing - Updates documentation with instructions on how to download and use the temporary builds from GitHub Actions artifacts
- Upgrades the
deltalakedependency from version0.29.3to0.29.4
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/user/README.md | Adds new "Installation from Builds" section documenting how to access temporary builds from GitHub Actions artifacts |
| .github/workflows/build-lint-test-and-upload.yml | Renames workflow, removes redundant Windows-specific setup, standardizes quote styles, reorders Python build steps, and adds new job to build and upload binaries for all platforms |
| Cargo.toml | Updates deltalake dependency from 0.29.3 to 0.29.4 |
| Cargo.lock | Updates lockfile with new deltalake version and its transitive dependencies (ctor, ctor-proc-macro, dtor, dtor-proc-macro) |
| crates/modelardb_embedded/bindings/python/docs/_static/.gitignore | Adds .gitignore file with Apache license header to ensure the _static directory exists for Sphinx |
Comments suppressed due to low confidence (2)
.github/workflows/build-lint-test-and-upload.yml:188
- On Windows, executable files require the
.exeextension. Themvcommands will fail because the source files are namedmodelardb.exe,modelardbb.exe,modelardbd.exe, andmodelardbm.exeon Windows, not without the extension. Consider adding conditional logic to handle the Windows case:
if [[ "$RUNNER_OS" == "Windows" ]]; then
mv target/release/modelardb.exe modelardb_$RUST_TRIPLE/
mv target/release/modelardbb.exe modelardb_$RUST_TRIPLE/
mv target/release/modelardbd.exe modelardb_$RUST_TRIPLE/
mv target/release/modelardbm.exe modelardb_$RUST_TRIPLE/
else
mv target/release/modelardb modelardb_$RUST_TRIPLE/
mv target/release/modelardbb modelardb_$RUST_TRIPLE/
mv target/release/modelardbd modelardb_$RUST_TRIPLE/
mv target/release/modelardbm modelardb_$RUST_TRIPLE/
fi.github/workflows/build-lint-test-and-upload.yml:161
- Grammar error in the comment: "reduce" should be "reduces". The comment should read:
# --jobs 1 reduces resource use.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CGodiksen
approved these changes
Nov 16, 2025
chrthomsen
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly closes #364 by creating builds for
aarch64 macOS,x86_64 Windows, andx86_64 Linuxfor each commit to themainbranch and uploading them to GitHub as Artifacts. Thus, the latest builds can be found in the Artifacts window for the latest Workflow that completed successfully. To make users aware of this, the installation documentation has been extended with information about how to install ModelarDB from these builds. While extending the main GitHub Action to create builds, unnecessary steps were also removed, and the workflow was made as consistent as possible. The-Wwas also added tosphinx.cmd.buildto make GitHub Action stop if an error occurs. Thus, asphinxerror and asphinxwarning also had to be fixed. Finally, a tiny update todeltalakewas included to not require an entire PR for such a small change.As this PR creates builds for some platforms, it is also a step towards #210. To create stable versioned releases from the builds created by this PR, a workflow that only runs when a version tag is being pushed can probably be used, e.g.,
on: push: tags: - 'v*'. This workflow can then just download the build artifacts and create a release from them, similar to the steps shown below. Although be aware that these steps are not thoroughly tested. Also, see the documentation for softprops/action-gh-release for how to automatically setnameandtag_nameinstead of hardcoding them as in the example below.