Skip to content

Conversation

@jonc125
Copy link
Contributor

@jonc125 jonc125 commented Apr 20, 2020

Description

Cope nicely if modellers stick a cmeta:id on a non-source variable that gets elided when resolving connections.

Motivation and Context

Fixes #267.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage

@jonc125 jonc125 self-assigned this Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #269 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #269   +/-   ##
========================================
  Coverage    97.43%   97.44%           
========================================
  Files            7        7           
  Lines         1327     1329    +2     
  Branches       288      289    +1     
========================================
+ Hits          1293     1295    +2     
  Misses          15       15           
  Partials        19       19           
Impacted Files Coverage Δ
cellmlmanip/model.py 99.54% <100.00%> (+<0.01%) ⬆️
cellmlmanip/units.py 98.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2bea79...3c344a8. Read the comment docs.

@jonc125 jonc125 requested a review from MauriceHendrix April 20, 2020 15:52
Copy link
Contributor

@MauriceHendrix MauriceHendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works a treat thanks!

@jonc125 jonc125 merged commit 8779183 into develop Apr 20, 2020
@jonc125 jonc125 deleted the 267-fix-connections branch April 20, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NetworkXError: node is not in the graph - error in connecting nodes & transferring metadata?

3 participants