Skip to content

Conversation

@kwabenantim
Copy link
Member

@kwabenantim kwabenantim commented Feb 7, 2025

Description

  • Support Python 3.12 and 3.13
  • Drop support for Python 3.6 to 3.8

Motivation and Context

Closes #374

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@kwabenantim kwabenantim self-assigned this Feb 7, 2025
@kwabenantim
Copy link
Member Author

kwabenantim commented Feb 7, 2025

@MichaelClerx does a release 0.4.0 sound sensible?

@kwabenantim
Copy link
Member Author

Codecov seems to have problems uploading:

==> Running upload-coverage
      ./codecov upload-coverage --git-service github --sha d72f7eae25bba61dcabb4ee27327d9cb1c1965c9 --gcov-executable gcov
info - 2025-02-07 12:22:46,715 -- ci service found: github-actions
warning - 2025-02-07 12:22:46,739 -- xcrun is not installed or can't be found.
warning - 2025-02-07 12:22:46,742 -- No gcov data found.
info - 2025-02-07 12:22:46,742 -- Generating coverage.xml report in /home/runner/work/cellmlmanip/cellmlmanip
info - 2025-02-07 12:22:47,082 -- Wrote XML report to coverage.xml
info - 2025-02-07 12:22:47,093 -- Found 1 coverage files to report
info - 2025-02-07 12:22:47,093 -- > /home/runner/work/cellmlmanip/cellmlmanip/coverage.xml
info - 2025-02-07 12:22:47,441 -- Process Upload complete
error - 2025-02-07 12:22:47,441 -- Upload failed: {"message":"Token required because branch is protected"}

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (46a9ba7) to head (73c0cb1).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1594      1594           
  Branches       362       327   -35     
=========================================
  Hits          1594      1594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelClerx
Copy link
Contributor

MichaelClerx commented Feb 7, 2025 via email

@kwabenantim
Copy link
Member Author

does a release 0.4.0 sound sensible?

I've made it version 0.3.7 in line with previous changes for Python version support.

@kwabenantim
Copy link
Member Author

kwabenantim commented Feb 10, 2025

Are you happy for this to go in with the new commits @MichaelClerx ?

@MichaelClerx
Copy link
Contributor

Yup!

@kwabenantim kwabenantim merged commit ee62dc8 into master Feb 10, 2025
22 checks passed
@kwabenantim kwabenantim deleted the support-python312 branch February 10, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3.12 and 3.13

3 participants