[codex] Fix Livewire and Blade view isolation under coroutines#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds coroutine-safe Livewire rendering support for Swoole and fixes per-coroutine Blade view isolation for Filament/Livewire pages.
The first fix serializes Livewire render/flush sections with a coroutine-aware reentrant mutex. Local app verification showed that was not sufficient by itself: Filament still failed because cloned view factories inherited the base
__envshare, so compiled Blade component stack state could escape the coroutine-scoped view factory.v0.8.13updatesRequestScopeso each cloned view factory shares itself as__env.Validation
/opt/homebrew/Cellar/php@8.3/8.3.29/bin/php ./vendor/bin/phpunit --filter 'LivewireCoroutineMutexTest|RequestScopeViewIsolationTest'uncensored-chat-fullstackvia tagv0.8.13/admin/loginreturns 200 under Swoole after this tag; it failed underv0.8.12Release
Tagged as
v0.8.13atf356514ab2d379126cb4ca892af871b34da52795.