Skip to content

Some mixins are incorrectly marked as "remap = false" #101

@paulevsGitch

Description

@paulevsGitch

Some mixins are marked as not remapped which result with crash outside of IDE:

[21:44:58] [AWT-EventQueue-0/ERROR] (FabricLoader/Mixin) Mixin apply for mod station-vanilla-checker-v0 failed station-vanilla-checker-v0.mixins.json:LoginHelloPacketMixin from mod station-vanilla-checker-v0 -> net.minecraft.class_118: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @ModifyConstant annotation on stationapi_injectHugeStringLimit could not find any targets matching 'read' in net.minecraft.class_118. Using refmap station-vanilla-checker-v0-refmap.json [PREINJECT Applicator Phase -> station-vanilla-checker-v0.mixins.json:LoginHelloPacketMixin from mod station-vanilla-checker-v0 -> Prepare Injections -> -> constant$zib000$station-vanilla-checker-v0$stationapi_injectHugeStringLimit(I)I -> Parse]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @ModifyConstant annotation on stationapi_injectHugeStringLimit could not find any targets matching 'read' in net.minecraft.class_118. Using refmap station-vanilla-checker-v0-refmap.json [PREINJECT Applicator Phase -> station-vanilla-checker-v0.mixins.json:LoginHelloPacketMixin from mod station-vanilla-checker-v0 -> Prepare Injections -> -> constant$zib000$station-vanilla-checker-v0$stationapi_injectHugeStringLimit(I)I -> Parse]

This is issue with at least one mixin: https://github.com/ModificationStation/StationAPI/blob/master/station-vanilla-checker-v0/src/main/java/net/modificationstation/stationapi/mixin/network/LoginHelloPacketMixin.java#L56

It marked as not required remapping, while remapping is required: read is method_806

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions