Bootstrap Providers

[Mbusibf]

Hi Daniel,

Thank you for the ismodular project.

I just have an idea regarding the provders file inside bootstrap folder. We could make it a little dynamic to register all providers from the modules folder.

See my suggested idea below:

// --------- default -------------
return [
    App\Providers\AppServiceProvider::class,

    Modules\Support\SupportServiceProvider::class,
    Modules\AdminAuth\AdminAuthServiceProvider::class,
    Modules\User\UserServiceProvider::class,
    Modules\Dashboard\DashboardServiceProvider::class,
    Modules\Acl\AclServiceProvider::class,
];

// --------- suggested idea -------------
$base_path = base_path();
$dir_path = $base_path . "\modules";
$dir = new DirectoryIterator($dir_path);
$providers_arr = [App\Providers\AppServiceProvider::class];
foreach ($dir as $file_info) {
    if (!$file_info->isDot()) {
        $moduleName = $file_info->getFilename();
        $provider_name = $moduleName.'ServiceProvider.php';
        $class_name = $moduleName.'ServiceProvider';
            if(file_exists($file_info->getPathname(). '\\'.$provider_name)) {
                $providers_arr = array_merge($providers_arr, ['Modules\\'.$moduleName.'\\'.$class_name]);
            }
    }
}

return $providers_arr;

I am currently using this in my project and it is working really well.

[daniel-cintra]

Hi @Mbusibf !

The configureModulesProviders method in src/Console/InstallerTraits/CoreModules.php adds the five Modular Core Modules (after Laravel’s App\Providers\AppServiceProvider) to bootstrap/providers.php. Because core modules do not tend to grow (extended functionality can be added by connecting modules) the existent declarative approach is easier to read and follow. It’s worth noting that, after installation, creating new modules with php artisan modular:make-module YourModuleName automatically registers the new module for you in bootstrap/providers.php, so there is no need to modify the installer for this use case.

Thank you!
All the best,
Daniel

[Mbusibf]

Hi Daniel, makes a lot of sense.

Thank you for the explanation.