Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

remove options.modules in babelTranspile#481

Closed
wyntau wants to merge 1 commit intoModuleLoader:masterfrom
wyntau:patch-1
Closed

remove options.modules in babelTranspile#481
wyntau wants to merge 1 commit intoModuleLoader:masterfrom
wyntau:patch-1

Conversation

@wyntau
Copy link

@wyntau wyntau commented Mar 19, 2016

options.modules = 'system' is deprecated in Babel 6

And this will lead to error

Using removed Babel 5 option: base.modules - Use the corresponding module transform plugin in the plugins option. Check out http://babeljs.io/docs/plugins/#modules(…)

options.modules = 'system' is deprecated in Babel 6
@wyntau
Copy link
Author

wyntau commented Mar 19, 2016

I make a demo to use systemjs and babel to load es6 module directly in browser. The demo will work only when I commen out options.modules = 'system'

@wyntau
Copy link
Author

wyntau commented Mar 26, 2016

Can anyone review this PR please?

@guybedford
Copy link
Member

The options.modules is critical to the Babel 5 support in this project. This feature will be deprecated though, and as such does not support Babel 6.

@guybedford guybedford closed this Mar 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants