Conversation
Migration 007: singleton row for genesis_complete, bootstrap_signing_pubkey_hex, modulr_apex_domain, updated_at — seed for modulr apex trust + wizard completion. CoreGenesisRepository with validation; tests and package export. Made-with: Cursor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a82b8c5933
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| d = domain.strip() | ||
| if not d: | ||
| raise ValueError("modulr_apex_domain must be non-empty when set") | ||
| if len(d) > _MODULR_APEX_DOMAIN_MAX_LEN: |
There was a problem hiding this comment.
set_modulr_apex_domain currently accepts any non-empty trimmed string up to 253 chars, so values like "not a domain" or single-label names can be persisted as modulr_apex_domain. Because this field is described as the apex trust domain, storing non-domain values creates invalid persistent state that later policy checks can mis-handle; validate against the existing org-domain rules (dotted DNS-style) before writing.
Useful? React with 👍 / 👎.
1 participant
Migration 007: singleton row for genesis_complete, bootstrap_signing_pubkey_hex, modulr_apex_domain, updated_at — seed for modulr apex trust + wizard completion.
CoreGenesisRepository with validation; tests and package export.