Conversation
Core: migration 013 (entity profile description), branding handlers and repository wiring, method catalog and operation dispatch updates, playground and validation tweaks, expanded HTTP/operations tests. Viewer: add Vite + React Router app with full-width shell, glass theming, home dashboard (recommended next + explore network), Inspector/Profile/Registration/Resolve/Methods, settings and notifications. Includes viewer/src/data module lists (gitignore: only ignore /data/ at repo root so SQLite path does not exclude viewer data). Frontend: methods mock and AppShell nav alignment. CI runs npm ci && npm run build in viewer/. README and smoke script updates. Made-with: Cursor
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61780fff4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| repo = NameBindingsRepository(conn) | ||
| now = int(clock()) | ||
| created_at, is_new = _insert_name_binding_idempotent( |
There was a problem hiding this comment.
When register_org is used to publish a module surface (signing_public_key set), this still performs strict idempotent insertion of the org binding with the incoming route_json before module upsert. For orgs that were previously registered without a route (or with a different route/metadata), _insert_name_binding_idempotent fails with NAME_ALREADY_BOUND, so the module row is never created. This blocks upgrading existing org registrations to module publishers, which was previously possible via register_module.
Useful? React with 👍 / 👎.
| "to mirror the row under h:<handle> as well as p:<pubkey>. Sender must " | ||
| "match the user key or be bootstrap—same as set_user_profile_image." | ||
| ), | ||
| payload_contract="user_profile_image_set", |
There was a problem hiding this comment.
set_user_description is declared with payload_contract="user_profile_image_set", but its payload shape is different (description text vs image base64/mime). Any discovery-driven client/tooling that maps request forms or validation from payload_contract will build the wrong schema and generate invalid requests for this method.
Useful? React with 👍 / 👎.
1 participant
Core: migration 013 (entity profile description), branding handlers and repository wiring, method catalog and operation dispatch updates, playground and validation tweaks, expanded HTTP/operations tests.
Viewer: add Vite + React Router app with full-width shell, glass theming, home dashboard (recommended next + explore network), Inspector/Profile/Registration/Resolve/Methods, settings and notifications. Includes viewer/src/data module lists (gitignore: only ignore /data/ at repo root so SQLite path does not exclude viewer data).
Frontend: methods mock and AppShell nav alignment. CI runs npm ci && npm run build in viewer/. README and smoke script updates.