Conversation
…acts - register_org: when publishing a module (signing_public_key set), allow refreshing an existing name_bindings row for the same resolved_id instead of NAME_ALREADY_BOUND, so orgs registered without a route can add a module row later. - NameBindingsRepository: add update_route_metadata for that upgrade path. - wire_method_catalog: advertise user_description_get / user_description_set instead of reusing user_profile_image_* contracts for description methods. - tests: cover register_org module publish after plain org binding. Made-with: Cursor
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22b7ff1d73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name=name, | ||
| resolved_id=resolved_id, | ||
| route_json=route_json, | ||
| metadata_json=meta_json, | ||
| ) |
There was a problem hiding this comment.
When register_org upgrades an existing org to module publisher, this branch always writes metadata_json=meta_json from the new request. Because metadata is optional, callers that omit it (as in the new helper payload) pass None and silently clear previously stored org metadata even though they only intended to add module publishing fields. This introduces data loss for clients that later read org metadata via name resolution.
Useful? React with 👍 / 👎.
| p.add_argument( | ||
| "--base-url", | ||
| default="http://127.0.0.1:8000", | ||
| default="https://127.0.0.1:8000", |
There was a problem hiding this comment.
The default --base-url was switched to HTTPS, but the script still constructs httpx.Client(...) with default certificate verification and provides no flag for a custom CA or insecure mode. In common local-dev setups using self-signed or locally-issued certs, the documented default command now fails with TLS verification errors before any smoke checks run, making the default path unusable.
Useful? React with 👍 / 👎.
- register_org: on module-publisher upgrade path, if payload omits metadata, keep existing name_bindings metadata_json instead of clearing it; explicit null still clears. - smoke_local: add --insecure to disable TLS verify for https:// with dev self-signed certificates; document in module docstring and epilog. - tests: assert metadata survives upgrade when second request has no metadata. Made-with: Cursor
1 participant
No description provided.